Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update citation with 2024 preprint #371

Merged
merged 9 commits into from
Jun 13, 2024

Conversation

fyvon
Copy link
Member

@fyvon fyvon commented Jun 7, 2024

... and added full list of publications to 'About > Citation' section

@fyvon fyvon requested a review from ens-lgil June 7, 2024 12:09
@fyvon fyvon linked an issue Jun 7, 2024 that may be closed by this pull request
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would have liked to use a reference to a schema to avoid duplicate lines but the 'authors' value is different for citation and pgs_catalog_publications

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok I see. The structure is slighlty different.
There is a way to extend a schema, by redefining it, e.g.:

Citation:
    type: object
    description: "Information about the latest PGS Catalog publication"
    properties:
         title:
            type: string
            description: "Title of the publication"
            example: 'The Polygenic Score Catalog as an open database for reproducibility and systematic evaluation'
         ...
         authors:
            type: string
            description: "List of the publication authors"
            example: 'Samuel A. Lambert, ... , Michael Inouye'
         ...

And the extra schema (not sure about the term Citation_extended):

Citation_extended:
      type: object
      description: "Based on the **Citation** schema, with the modification of the '**authors**'."
      allOf:
        - $ref: '#/components/schemas/Citation'
        - type: object
          properties:
              authors:
                type: string
                description: "Publication first author(s)"
                 example: 'Lambert et al'

But that might be a bit overkilling ...

@fyvon fyvon merged commit b492201 into PGScatalog:master Jun 13, 2024
@fyvon fyvon deleted the update/citation_2024 branch June 13, 2024 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add new preprint citation to the website
2 participants