-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stabilize tests #27
Comments
danielhollas
added a commit
that referenced
this issue
Jan 20, 2021
Github will soon switch it's 'ubuntu-latest' runner to 'ubuntu-20.04' and we're not ready: 1. Some tests are failing with minor numerical differences on 20.04 Hopefully this get's solved with #27. 2. Some jobs in GFortran CI config now rely on the fact that the default GCC/GFortran version is 7. We'll need to make that explicit if we want to switch to 20.04. We want to keep the default version = 7 since that's the one we're using on the PHOTOX clusters. 3. Given our ancient Linux versions on PHOTOX clusters, it probably makes sense to stick to 18.04 for now. (and maybe in the future switch one job to 20.04)
danielhollas
added a commit
that referenced
this issue
Jan 20, 2021
Github will soon switch it's 'ubuntu-latest' runner to 'ubuntu-20.04' and we're not ready: 1. Some tests are failing with minor numerical differences on 20.04 Hopefully this get's solved with #27. 2. Some jobs in GFortran CI config now rely on the fact that the default GCC/GFortran version is 7. We'll need to make that explicit if we want to switch to 20.04. We want to keep the default version = 7 since that's the one we're using on the PHOTOX clusters. 3. Given our ancient Linux versions on PHOTOX clusters, it probably makes sense to stick to 18.04 for now. (and maybe in the future switch one job to 20.04)
danielhollas
added a commit
that referenced
this issue
Jan 27, 2021
Codecov reports from Basic build with GFortran 8 and 9 were crashing because we were not setting the correct 'gcov' version. Some caches we're used incorrectly. The GA config is getting a bit unwieldy. :-( GA: Pin Ubuntu version to 18.04: Github will soon switch it's 'ubuntu-latest' runner to 'ubuntu-20.04' and we're not ready: 1. Some tests are failing with minor numerical differences on 20.04 Hopefully this get's solved with #27. 2. Some jobs in GFortran CI config now rely on the fact that the default GCC/GFortran version is 7. We'll need to make that explicit if we want to switch to 20.04. We want to keep the default version = 7 since that's the one we're using on the PHOTOX clusters. 3. Given our ancient Linux versions on PHOTOX clusters, it probably makes sense to stick to 18.04 for now. (and maybe in the future switch one job to 20.04) GA: Separate unit tests from end-to-end tests This is just for a convenience, to make it easier to inspect Github Action workflows. This will matter more as we'll add more unit tests. :-) This also makes the Makefile a bit more consistent, treating e2e and unit tests on equal footing.
danielhollas
added a commit
that referenced
this issue
Jan 28, 2021
Codecov reports from Basic build with GFortran 8 and 9 were crashing because we were not setting the correct 'gcov' version. Some caches we're used incorrectly. The GA config is getting a bit unwieldy. :-( GA: Pin Ubuntu version to 18.04: Github will soon switch it's 'ubuntu-latest' runner to 'ubuntu-20.04' and we're not ready: 1. Some tests are failing with minor numerical differences on 20.04 Hopefully this get's solved with #27. 2. Some jobs in GFortran CI config now rely on the fact that the default GCC/GFortran version is 7. We'll need to make that explicit if we want to switch to 20.04. We want to keep the default version = 7 since that's the one we're using on the PHOTOX clusters. 3. Given our ancient Linux versions on PHOTOX clusters, it probably makes sense to stick to 18.04 for now. (and maybe in the future switch one job to 20.04) GA: Separate unit tests from end-to-end tests This is just for a convenience, to make it easier to inspect Github Action workflows. This will matter more as we'll add more unit tests. :-) This also makes the Makefile a bit more consistent, treating e2e and unit tests on equal footing.
danielhollas
added a commit
that referenced
this issue
Jan 28, 2021
- Codecov reports from with GFortran 8 and 9 were crashing because we were not setting the correct 'gcov' version. - Some caches were not used incorrectly. The GA config is getting a bit unwieldy. :-( - GA: Pin Ubuntu version to 18.04: Github will soon switch it's 'ubuntu-latest' runner to 'ubuntu-20.04' and we're not ready: 1. Some tests are failing with minor numerical differences on 20.04 Hopefully this get's solved with #27. 2. Some jobs in GFortran CI config now rely on the fact that the default GCC/GFortran version is 7. We'll need to make that explicit if we want to switch to 20.04. We want to keep the default version = 7 since that's the one we're using on the PHOTOX clusters. 3. Given our ancient Linux versions on PHOTOX clusters, it probably makes sense to stick to 18.04 for now. (and maybe in the future switch one job to 20.04) - GA: Separate unit tests from end-to-end tests This is just for a convenience, to make it easier to inspect Github Action workflows. This will matter more as we'll add more unit tests. :-) This also makes the Makefile a bit more consistent; treating e2e and unit tests on equal footing.
danielhollas
added a commit
that referenced
this issue
Jan 28, 2021
- Codecov reports from with GFortran 8 and 9 were crashing because we were not setting the correct 'gcov' version. - Some caches were not used incorrectly. The GA config is getting a bit unwieldy. :-( - GA: Pin Ubuntu version to 18.04: Github will soon switch it's 'ubuntu-latest' runner to 'ubuntu-20.04' and we're not ready: 1. Some tests are failing with minor numerical differences on 20.04 Hopefully this get's solved with #27. 2. Some jobs in GFortran CI config now rely on the fact that the default GCC/GFortran version is 7. We'll need to make that explicit if we want to switch to 20.04. We want to keep the default version = 7 since that's the one we're using on the PHOTOX clusters. 3. Given our ancient Linux versions on PHOTOX clusters, it probably makes sense to stick to 18.04 for now. (and maybe in the future switch one job to 20.04) - GA: Separate unit tests from end-to-end tests This is just for a convenience, to make it easier to inspect Github Action workflows. This will matter more as we'll add more unit tests. :-) This also makes the Makefile a bit more consistent; treating e2e and unit tests on equal footing.
danielhollas
added a commit
that referenced
this issue
Jan 28, 2021
- Codecov reports from with GFortran 8 and 9 were crashing because we were not setting the correct 'gcov' version. - Some caches were not used incorrectly. The GA config is getting a bit unwieldy. :-( - GA: Pin Ubuntu version to 18.04: Github will soon switch it's 'ubuntu-latest' runner to 'ubuntu-20.04' and we're not ready: 1. Some tests are failing with minor numerical differences on 20.04 Hopefully this get's solved with #27. 2. Some jobs in GFortran CI config now rely on the fact that the default GCC/GFortran version is 7. We'll need to make that explicit if we want to switch to 20.04. We want to keep the default version = 7 since that's the one we're using on the PHOTOX clusters. 3. Given our ancient Linux versions on PHOTOX clusters, it probably makes sense to stick to 18.04 for now. (and maybe in the future switch one job to 20.04) - GA: Separate unit tests from end-to-end tests This is just for a convenience, to make it easier to inspect Github Action workflows. This will matter more as we'll add more unit tests. :-) This also makes the Makefile a bit more consistent; treating e2e and unit tests on equal footing.
danielhollas
added a commit
that referenced
this issue
Feb 1, 2021
- Codecov reports from with GFortran 8 and 9 were crashing because we were not setting the correct 'gcov' version. - Some caches were not used incorrectly. The GA config is getting a bit unwieldy. :-( - GA: Pin Ubuntu version to 18.04: Github will soon switch it's 'ubuntu-latest' runner to 'ubuntu-20.04' and we're not ready: 1. Some tests are failing with minor numerical differences on 20.04 Hopefully this get's solved with #27. 2. Some jobs in GFortran CI config now rely on the fact that the default GCC/GFortran version is 7. We'll need to make that explicit if we want to switch to 20.04. We want to keep the default version = 7 since that's the one we're using on the PHOTOX clusters. 3. Given our ancient Linux versions on PHOTOX clusters, it probably makes sense to stick to 18.04 for now. (and maybe in the future switch one job to 20.04) - GA: Separate unit tests from end-to-end tests This is just for a convenience, to make it easier to inspect Github Action workflows. This will matter more as we'll add more unit tests. :-) This also makes the Makefile a bit more consistent; treating e2e and unit tests on equal footing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
We should modify tests so that each test is only 1 or 2 MD steps (+restart). That should minimize the differences between compilers/machines so we could be more strict when comparing against reference values.
The text was updated successfully, but these errors were encountered: