DX: use PHPUnit's "requires" instead of "if" condition (#6975)

PHP-CS-Fixer · May 19, 2023 · a3ed743 · a3ed743
1 parent 96d8856
commit a3ed743
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 12 deletions.
diff --git a/tests/Fixer/CastNotation/LowercaseCastFixerTest.php b/tests/Fixer/CastNotation/LowercaseCastFixerTest.php
@@ -35,13 +35,11 @@ public function testFix(string $expected, ?string $input = null): void
      * @dataProvider provideFixDeprecatedCases
      *
      * @group legacy
+     *
+     * @requires PHP <8.0
      */
     public function testFix74Deprecated(string $expected, ?string $input = null): void
     {
-        if (\PHP_VERSION_ID >= 8_00_00) {
-            self::markTestSkipped('PHP < 8.0 is required.');
-        }
-
         $this->expectDeprecation('%AThe (real) cast is deprecated, use (float) instead');
 
         $this->doTest($expected, $input);

diff --git a/tests/Fixer/CastNotation/ShortScalarCastFixerTest.php b/tests/Fixer/CastNotation/ShortScalarCastFixerTest.php
@@ -35,13 +35,11 @@ public function testFix(string $expected, ?string $input = null): void
      * @dataProvider provideFixDeprecatedCases
      *
      * @group legacy
+     *
+     * @requires PHP <8.0
      */
     public function testFix74Deprecated(string $expected, ?string $input = null): void
     {
-        if (\PHP_VERSION_ID >= 8_00_00) {
-            self::markTestSkipped('PHP < 8.0 is required.');
-        }
-
         $this->expectDeprecation('%AThe (real) cast is deprecated, use (float) instead');
 
         $this->doTest($expected, $input);

diff --git a/tests/Tokenizer/Transformer/NameQualifiedTransformerTest.php b/tests/Tokenizer/Transformer/NameQualifiedTransformerTest.php
@@ -36,6 +36,8 @@ final class NameQualifiedTransformerTest extends AbstractTransformerTestCase
      * @param null|Token[] $input
      *
      * @dataProvider provideProcessCases
+     *
+     * @requires PHP 8.0
      */
     public function testProcess(array $expected, array $input = null): void
     {
@@ -62,10 +64,6 @@ public function testProcess(array $expected, array $input = null): void
 
     public static function provideProcessCases(): iterable
     {
-        if (\PHP_VERSION_ID < 8_00_00) {
-            return; // PHPUnit still calls this for no reason on non PHP8.0
-        }
-
         yield 'string' => [
             [
                 new Token([T_OPEN_TAG, "<?php\n"]),