Add support for PHPUnit 6, drop PHPUnit 4 #3182
Conversation
keradus
force-pushed
the
2.7_phpunit
branch
2 times, most recently
from
4dacac1
to
a7486f3
Compare
composer.json
Outdated
| "justinrainbow/json-schema": "^5.0", | ||
| "php-cs-fixer/accessible-object": "^1.0", | ||
| "phpunit/phpunit": "^4.8.35 || ^5.4.3", | ||
| "phpunit/phpunit": "^5.7.23 || ^6.4.3", |
There was a problem hiding this comment.
Sort dependencies by the way?
keradus
force-pushed
the
2.7_phpunit
branch
2 times, most recently
from
28b0656
to
0f88fd6
Compare
| $this->setExpectedException( | ||
| \PhpCsFixer\ConfigurationException\InvalidConfigurationException::class, | ||
| $this->expectException( | ||
| \PhpCsFixer\ConfigurationException\InvalidConfigurationException::class |
There was a problem hiding this comment.
Quick note: it appears that PhpCsFixer\ConfigurationException\InvalidConfigurationException has already been imported, so while this out of scope of the changes suggested in this PR, what do you think about simplifying the FQCN here, as well as putting the invocation on a single line?
There was a problem hiding this comment.
doing it in this one place is pointless, we already have a future request to import all usages like here, that would fix issue globally
| @@ -5,7 +5,6 @@ clone_folder: C:\projects\php-cs-fixer | |||
|
|
|||
| environment: | |||
| matrix: | |||
| - php_ver: 7.1.2 | |||
There was a problem hiding this comment.
What was wrong with this version?
There was a problem hiding this comment.
it was freezing on phpunit execution
|
Arf, already merged, but 👍 anyway :) |
|
done by #3201 |
No description provided.