New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PhpdocAnnotationWithoutDotFixer - add failing cases #4027
Conversation
@kubawerlos , can you take a look on this one, please ? |
I see no simple solution for this - the actually broken PHPDoc (with missing What do you think about reverting #3882 for now, then updating |
Changing DocBLock* has unpredictable consequences :( |
We could give it a try... or assume that PHPDocs with gaps in asterisk are not handles as its have asterisk where missing => remove both test cases with missing asterisk and revert #3882 "fix". |
indeed, when asterisks are missing, phpdoc is malformed and let not modify it |
can you take a look, @kubawerlos ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good 👍
Thanks @keradus. |
(not sure why GH doens't state this PR as |
(as I see squashed commit went to target branch, but PR was not updated with squashed commit) |
This PR was merged into the 2.8 branch. Discussion ---------- Revert "fixed CS" This reverts commit d48a377. | Q | A | ------------- | --- | Branch? | 2.8 | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | n/a | Fixed tickets | n/a | License | MIT | Doc PR | n/a This PR reverts #28814 , that was caused as a bug of PHP CS Fixer fixed in PHP-CS-Fixer/PHP-CS-Fixer#4027 After fix on PHP CS Fixer side, the rule is passing now at Symfony's codebase. This PR only reverts wrong chances done by PHP CS Fixer, it does not apply new rule requested in #28817 ( PHP-CS-Fixer/PHP-CS-Fixer#4045 ) Commits ------- 6f83d9f Revert "fixed CS"
This PR was merged into the 2.8 branch. Discussion ---------- Revert "fixed CS" This reverts commit d48a3776fe0b425d41e3fa9f3ef8b14315c02a1f. | Q | A | ------------- | --- | Branch? | 2.8 | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | n/a | Fixed tickets | n/a | License | MIT | Doc PR | n/a This PR reverts #28814 , that was caused as a bug of PHP CS Fixer fixed in PHP-CS-Fixer/PHP-CS-Fixer#4027 After fix on PHP CS Fixer side, the rule is passing now at Symfony's codebase. This PR only reverts wrong chances done by PHP CS Fixer, it does not apply new rule requested in #28817 ( PHP-CS-Fixer/PHP-CS-Fixer#4045 ) Commits ------- 6f83d9f9a3 Revert "fixed CS"
introduced in #3882
ref symfony/symfony#28814
ref symfony/symfony#28817