CS fixes #28814
CS fixes #28814
Conversation
fabpot
commented
Oct 11, 2018
fabpot
commented
| Q | A |
|---|---|
| Branch? | 2.8 |
| Bug fix? | no |
| New feature? | o |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | n/a |
| License | MIT |
| Doc PR | n/a |
| @@ -41,8 +41,8 @@ public function __construct(ContainerInterface $container) | |||
| * | |||
| * @param string $eventName The name of the event to dispatch. The name of the event is | |||
There was a problem hiding this comment.
Don't we then need to change the description here too?
There was a problem hiding this comment.
I agree, but out of the scope of this PR. I just want the code to have 0 CS errors. If someone wants to improve the current description, they are more than welcome, but I would not see that as a priority.
There was a problem hiding this comment.
I agree, I was just wondering why the fixer complained about one case while leaving the other untouched.
There was a problem hiding this comment.
indeed, I don't understand why this is not fixed. /cc @SpacePossum @keradus
This PR was merged into the 2.8 branch. Discussion ---------- CS fixes | Q | A | ------------- | --- | Branch? | 2.8 | Bug fix? | no | New feature? | o <!-- don't forget to update src/**/CHANGELOG.md files --> | BC breaks? | no <!-- see https://symfony.com/bc --> | Deprecations? | no <!-- don't forget to update UPGRADE-*.md and src/**/CHANGELOG.md files --> | Tests pass? | yes <!-- please add some, will be required by reviewers --> | Fixed tickets | n/a | License | MIT | Doc PR | n/a <!-- Write a short README entry for your feature/bugfix here (replace this comment block.) This will help people understand your PR and can be used as a start of the Doc PR. Additionally: - Bug fixes must be submitted against the lowest branch where they apply (lowest branches are regularly merged to upper ones so they get the fixes too). - Features and deprecations must be submitted against the master branch. --> Commits ------- d48a377 fixed CS
|
Hi @fabpot , thanks for note. If description is a multiple sentences, rule shall not change it. This is good change: -@param string $foo Description of param.
+@param string $foo description of paramThis is not a good change: -@param string $foo Description of param. Multiple sentences.
+@param string $foo description of param. Multiple sentencesThis bug will be fixed in next 2.12 release, see PR to see state of work on that: |
|
This PR follows after tool, but it introduces bad changes, that won't happen anymore after fix on PHP CS Fixer side. |
This PR was squashed before being merged into the 2.12 branch (closes #4027). Discussion ---------- PhpdocAnnotationWithoutDotFixer - add failing cases introduced in #3882 ref symfony/symfony#28814 ref symfony/symfony#28817 Commits ------- 330fe39 PhpdocAnnotationWithoutDotFixer - add failing cases
This PR was merged into the 2.8 branch. Discussion ---------- Revert "fixed CS" This reverts commit d48a377. | Q | A | ------------- | --- | Branch? | 2.8 | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | n/a | Fixed tickets | n/a | License | MIT | Doc PR | n/a This PR reverts #28814 , that was caused as a bug of PHP CS Fixer fixed in PHP-CS-Fixer/PHP-CS-Fixer#4027 After fix on PHP CS Fixer side, the rule is passing now at Symfony's codebase. This PR only reverts wrong chances done by PHP CS Fixer, it does not apply new rule requested in #28817 ( PHP-CS-Fixer/PHP-CS-Fixer#4045 ) Commits ------- 6f83d9f Revert "fixed CS"
