TrailingCommaInMultilineFixer - introduction

[kubawerlos]

Resolves #4135

[erickskrauch]

@SpacePossum any news about merging this?

[SpacePossum]

Thanks for opening this PR!

I'm not sure if merging the fixer for array declaring and function calling is a good idea.
On your own points:
1 - sounds ok to me
2 - sounds ok to me
3 - see below
4 - see below
5 - for later

please add this test

<?php
while(
(
(
$a
)
)
) {}

[Wojciechem]

I'd highly appreciate this feature - what's the status, can I help?

[kubawerlos]

@Wojciechem you can make a review - e.g. proposing more test case and different naming/description if you think some would fit better.

[kunicmarko20]

btw, I don't see any test case for method calls, something like:

$obj->method(
    1,
    2,
);

[kunicmarko20]

@kubawerlos what do you think about this being 2 separate fixers? I would love to help with this

[erickskrauch]

I think it should be a separate fixer: it requires a minimum version of PHP 7.3.

[kubawerlos]

it requires a minimum version of PHP 7.3.

@erickskrauch only the options function_calls and after_heredoc requires PHP 7.3.

[grachevko]

any news?

[kubawerlos]

@grachevko I guess it's waiting for review, so don't hesitate with doing it 😃

[GrahamCampbell]

Good work. I think another obvious thing to support is for function definitions as well as calls (incuding closures), and also unifying with the list stuff?

[GrahamCampbell]

@PHP73Migration ruleset needs updating, and also tests/Fixtures/Integration/misc/PHP7_4.test.

[GrahamCampbell]

Friendly ping @kubawerlos.

[artursvonda]

Bump! Would love to see this as well. Let me know if I can help.

[kubawerlos]

What is the direction this should go? Single fixer with options for arrays, functions calls and function declarations or seperate fixer for each?

Ping @keradus, @SpacePossum, @julienfalque, @localheinz

[keradus]

it's a shame we didn't managed to get conclusion in over a year.

@kubawerlos , can I ask you to rebase this PR and ensure CI is green? to get this PR finally merged, let's have this feature in a single fixer.

[coveralls]

Coverage increased (+0.01%) to 91.9% when pulling 5b36241 on kubawerlos:add-multiline-trailing-comma into 3d7e47c on FriendsOfPHP:master.

[keradus]

Thank you @kubawerlos.

[keradus]

@kubawerlos , can you drop the deprecated elements at 3.0 line?