Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DX: do not enforce time limits for tests #5434

Closed
wants to merge 2 commits into from
Closed

DX: do not enforce time limits for tests #5434

wants to merge 2 commits into from

Conversation

kubawerlos
Copy link
Contributor

Since:

PHP extension pcntl is required for enforcing time limits

and playing with time limits is not helpig much, let's try to not use pcntl .

@keradus
Copy link
Member

keradus commented Jan 13, 2021

and playing with time limits is not helpig much, let's try to not use pcntl .

we Drop speedtrap PHPUnit listener not because we have issues with weird slowness of tests reported, but because the feature got incorporated into PHPUnit itself and we no longer need dedicated listener for it

Also, i believe we simply misconfigured the feature - #5435

@kubawerlos kubawerlos changed the title DX: do not install pcntl extension on CI DX: do not enforce time limits for tests Jan 13, 2021
@coveralls
Copy link

Coverage Status

Coverage remained the same at 91.971% when pulling 94498b2 on kubawerlos:do-not-install-pcntl-extension-on-ci into 21934b5 on FriendsOfPHP:2.17.

@keradus
Copy link
Member

keradus commented Jan 14, 2021

green: #5435

@kubawerlos kubawerlos closed this Jan 14, 2021
@kubawerlos kubawerlos deleted the do-not-install-pcntl-extension-on-ci branch January 14, 2021 07:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants