Add support for nullsafe object operator ("?->") #5586
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keradus
approved these changes
Apr 14, 2021
|
Thank you @kubawerlos. |
keradus
reviewed
Apr 18, 2021
| yield [ | ||
| '<?php return $this->myObject1?->{$index}+$b === "";', | ||
| //null, | ||
| //['equal' => true, 'identical' => true] |
There was a problem hiding this comment.
@kubawerlos , should we uncomment? please take over and cleanup
keradus
added a commit
that referenced
this pull request
Apr 18, 2021
This PR was merged into the 3.0 branch. Discussion ---------- DX: YodaStyleFixerTest - fix CI I noticed it here: https://github.com/FriendsOfPHP/PHP-CS-Fixer/pull/5641/checks?check_run_id=2374783267 FYI @kubawerlos , looks like coming from #5586 Commits ------- e9cdb51 DX: YodaStyleFixerTest - fix CI
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The difference where you can use
T_OBJECT_OPERATOR, but cannotT_NULLSAFE_OBJECT_OPERATORis write context (see: https://3v4l.org/PJZJo).Current list of files having
T_OBJECT_OPERATOR:Initial list of files having
T_OBJECT_OPERATOR(there was no single occurrence ofT_NULLSAFE_OBJECT_OPERATOR):Closes #5584