Skip to content

Simplify DiffConsoleFormatter#6183

Merged
SpacePossum merged 1 commit intoPHP-CS-Fixer:masterfrom
werlos:simplify_DiffConsoleFormatter
Dec 16, 2021
Merged

Simplify DiffConsoleFormatter#6183
SpacePossum merged 1 commit intoPHP-CS-Fixer:masterfrom
werlos:simplify_DiffConsoleFormatter

Conversation

@kubawerlos
Copy link
Member

@kubawerlos kubawerlos commented Dec 15, 2021

This is actually only place where any Preg method is called with an array (of patterns), not a string.

To be continued: #6184.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 93.048% when pulling cf4dcc4 on werlos:simplify_DiffConsoleFormatter into 24999a0 on FriendsOfPHP:master.

@SpacePossum
Copy link
Contributor

Thank you @kubawerlos.

@SpacePossum SpacePossum merged commit b4b6d13 into PHP-CS-Fixer:master Dec 16, 2021
@kubawerlos kubawerlos deleted the simplify_DiffConsoleFormatter branch December 16, 2021 08:22
SpacePossum added a commit that referenced this pull request Dec 16, 2021
…los)

This PR was merged into the master branch.

Discussion
----------

Do not support array of patterns in Preg methods

Requires #6183 to be merged.

`Preg` is an internal class, so BC break is fine.

To be continued: #6185.

Commits
-------

b610b92 Do not support array of patterns in Preg methods
'/^(\-.*)/',
'/^(@.*)/',
],
'/^([+-@].*)/',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

Comments