Skip to content

Upgrade PHPStan#6185

Merged
SpacePossum merged 1 commit intoPHP-CS-Fixer:masterfrom
werlos:upgrade_phpstan
Dec 16, 2021
Merged

Upgrade PHPStan#6185
SpacePossum merged 1 commit intoPHP-CS-Fixer:masterfrom
werlos:upgrade_phpstan

Conversation

@kubawerlos
Copy link
Member

@kubawerlos kubawerlos commented Dec 15, 2021 •
edited
Loading

Requires #6184 to be merged.

After merging the PR above CI will be green.

The end 🎆

As an extra you can see here PHPStan error annotation in the diff (until it is fixed of course).

@coveralls
Copy link

coveralls commented Dec 15, 2021 •
edited
Loading

Coverage Status

Coverage remained the same at 93.037% when pulling 5661979 on werlos:upgrade_phpstan into d23cc90 on FriendsOfPHP:master.

@kubawerlos kubawerlos mentioned this pull request Dec 16, 2021
Merged
SpacePossum added a commit that referenced this pull request Dec 16, 2021
@SpacePossum
minor #6184 Do not support array of patterns in Preg methods (kubawer…
d23cc90 
…los)

This PR was merged into the master branch.

Discussion
----------

Do not support array of patterns in Preg methods

Requires #6183 to be merged.

`Preg` is an internal class, so BC break is fine.

To be continued: #6185.

Commits
-------

b610b92 Do not support array of patterns in Preg methods
@kubawerlos kubawerlos marked this pull request as ready for review December 16, 2021 08:46
SpacePossum
SpacePossum reviewed Dec 16, 2021
View reviewed changes
.github/workflows/sca.yml
with:
php-version: ${{ matrix.php-version }}
coverage: none # without this Xdebug will be enabled
tools: cs2pr
Copy link
Contributor

@SpacePossum SpacePossum Dec 16, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we see this @ work anywhere?

Copy link
Member Author

@kubawerlos kubawerlos Dec 16, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You could before I've rebased XD

@SpacePossum
Copy link
Contributor

SpacePossum commented Dec 16, 2021

Thank you @kubawerlos.

@SpacePossum SpacePossum merged commit 1f4f55a into PHP-CS-Fixer:master Dec 16, 2021
@kubawerlos kubawerlos deleted the upgrade_phpstan branch December 16, 2021 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@SpacePossum SpacePossum SpacePossum left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

kind/enhancement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@kubawerlos @coveralls @SpacePossum