New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bug: Fix PHPDoc alignment fixer containing callbacks using \Closure
#6746
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cs278
changed the title
Fix PHPDoc alignment fixer containing callbacks using
bug: Fix PHPDoc alignment fixer containing callbacks using Jan 9, 2023
\Closure
\Closure
keradus
reviewed
Jan 10, 2023
Pull Request Test Coverage Report for Build 3901039923
💛 - Coveralls |
keradus
reviewed
Jan 10, 2023
keradus
reviewed
Jan 10, 2023
keradus
reviewed
Jan 10, 2023
keradus
approved these changes
Jan 11, 2023
Kudos, @cs278 ! |
cs278
force-pushed
the
fix-closure-with-slash
branch
from
January 12, 2023 09:46
5c108d2
to
91809b0
Compare
kubawerlos
approved these changes
Jan 21, 2023
thank you @cs278 |
This has broken the tests. |
@GrahamCampbell what tests? |
Merged
@GrahamCampbell , I think you would be faster to actually raise a fix than raising an awareness that one see on main repo page anyway ;) |
@GrahamCampbell if you look into these there is no single test failing, just style check. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the PHPDoc alignment fixer so that
@param
annotations using\Closure
don't break the alignment, e.g.:Quite a simple change in the end, I've just updated the regexp in
TypeExpression
to handle the backslash.