-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DX: use only PHP modules that are required #6954
DX: use only PHP modules that are required #6954
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know whether we should merge it. Comparing CI workflows, the "Setup PHP" step takes similar time before and after change, so there's no gain in terms of running jobs.
The good part is that we have explicit list of extensions and we don't bloat runtime with them. If there is any code that depends on the list of installed extensions, it now has less to process. But it is micro-optimisation 😅.
Im am not against it, but at the same time I am not in favor that much. I am going to give approval and you can decide @kubawerlos.
Or maybe @keradus can look at it too.
Those times are random and undeterministic 😅. Some are better, some are worse 🤷♂️. It's OK for me both ways, I don't have much experience with that action so I can't tell which approach is better. I can ask somewhere 😉. |
Thank you @kubawerlos 🍻 |
Goal: performance? Smaller resource usage?
Initial situation (see logs from 1st commit):
After changes in this PR (see commit "Add zip"):