Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Support new/instanceof/use trait in fully_qualified_strict_types #7653

Merged
merged 8 commits into from
Jan 3, 2024
Merged

feat: Support new/instanceof/use trait in fully_qualified_strict_types #7653

merged 8 commits into from
Jan 3, 2024

Conversation

mvorisek
Copy link
Contributor

@mvorisek mvorisek commented Jan 1, 2024 •
edited

fix #5594
fix #7568

@mvorisek mvorisek force-pushed the fqcn_new branch 3 times, most recently from 359b001 to f77c29b Compare January 1, 2024 21:34
@mvorisek mvorisek mentioned this pull request Jan 1, 2024
Merged
@mvorisek mvorisek changed the title feat: Support new/instanceof in fully_qualified_strict_types feat: Support new/instanceof/trait in fully_qualified_strict_types Jan 1, 2024
@mvorisek mvorisek mentioned this pull request Jan 2, 2024
Merged
Wirone
Wirone requested changes Jan 2, 2024
View reviewed changes
Copy link
Member

@Wirone Wirone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! Some minor things to sort out.

src/Fixer/Import/FullyQualifiedStrictTypesFixer.php Outdated Show resolved Hide resolved
tests/Fixer/Import/FullyQualifiedStrictTypesFixerTest.php Outdated Show resolved Hide resolved
@mvorisek mvorisek requested a review from Wirone January 3, 2024 10:20
@mvorisek mvorisek changed the title feat: Support new/instanceof/trait in fully_qualified_strict_types feat: Support new/instanceof/use trait in fully_qualified_strict_types Jan 3, 2024
@Wirone Wirone enabled auto-merge (squash) January 3, 2024 10:35
@Wirone Wirone merged commit f1500e4 into PHP-CS-Fixer:master Jan 3, 2024
26 checks passed
@Wirone
Copy link
Member

Wirone commented Jan 3, 2024

Thank you very much @mvorisek 🍻!

@mvorisek mvorisek deleted the fqcn_new branch January 3, 2024 10:42
@Wirone Wirone added the topic/fqcn Fully Qualified Class Name usage and conversions label Jan 16, 2024
danog pushed a commit to zoonru/PHP-CS-Fixer that referenced this pull request Feb 2, 2024
@mvorisek @danog
feat: Support new/instanceof/use trait in `fully_qualified_strict_typ…
22143aa 
…es` (PHP-CS-Fixer#7653)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Wirone Wirone Wirone approved these changes

Assignees
No one assigned
Labels
topic/fqcn Fully Qualified Class Name usage and conversions
Projects
None yet
Milestone
No milestone
2 participants
@mvorisek @Wirone