-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Support named args in ParallelConfigFactory::detect()
#8026
Merged
Wirone
merged 6 commits into
PHP-CS-Fixer:master
from
Wirone:codito/parallel-config-named-args
May 20, 2024
Merged
fix: Support named args in ParallelConfigFactory::detect()
#8026
Wirone
merged 6 commits into
PHP-CS-Fixer:master
from
Wirone:codito/parallel-config-named-args
May 20, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wirone
force-pushed
the
codito/parallel-config-named-args
branch
from
May 20, 2024 11:39
829f985
to
8ace150
Compare
Wirone
force-pushed
the
codito/parallel-config-named-args
branch
from
May 20, 2024 12:00
8ace150
to
f114cfe
Compare
Steveb-p
reviewed
May 20, 2024
keradus
reviewed
May 20, 2024
keradus
reviewed
May 20, 2024
keradus
reviewed
May 20, 2024
We can't filter args for PHP <8 because then it's impossible to use default value for `$filesPerProcess`, calling `ParallelConfigFactory::detect(null, 360)` will just use 360 files per process and default timeout (120). Since `ParallelConfig`'s constructor requires explicit values, we can't keep `null` values passed to factory, because it would lead to type error, so we need to re-use default values on factory level (hence changed visibility of the constants).
Co-authored-by: Dariusz Rumiński <dariusz.ruminski@gmail.com>
Wirone
force-pushed
the
codito/parallel-config-named-args
branch
from
May 20, 2024 20:02
3aaa1c2
to
1235431
Compare
keradus
approved these changes
May 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8025