Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use fluent interface when defining mocks #458

Merged
merged 1 commit into from
Dec 16, 2017
Merged

Use fluent interface when defining mocks #458

merged 1 commit into from
Dec 16, 2017

Conversation

carusogabriel
Copy link
Contributor

Q A
Bug fix? Yes
New feature? no
BC breaks? Yes
Deprecations? Yes
Fixed tickets #412
Related issues/PRs #412 #455
License MIT

As suggested in #455, let's fix the tests step by step. First:

  • Use a fluent interface when defining Mocks. This fix tests Call to undefined method getMock().

@jens1o jens1o self-requested a review December 15, 2017 14:06
jens1o
jens1o requested changes Dec 15, 2017
View reviewed changes
Copy link
Member

@jens1o jens1o left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you use the ::class directive, instead of passing the classnames as strings? We do not support 5.3 in 1.x anymore :)

Thanks!

@carusogabriel
Copy link
Contributor Author

Done!

jens1o
jens1o approved these changes Dec 15, 2017
View reviewed changes
Copy link
Member

@jens1o jens1o left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome, thanks!

@jens1o
Copy link
Member

jens1o commented Dec 15, 2017

... but you need to check, that the interfaces complies with the method signatures :/

@carusogabriel
Copy link
Contributor Author

Should I fix the typos in this PR?

@jens1o
Copy link
Member

jens1o commented Dec 15, 2017

Yeah, please. I want to avoid merging something where tests are failing.

@carusogabriel
Copy link
Contributor Author

carusogabriel commented Dec 16, 2017 •
edited

Done! Now only setExpectedException fail tests remain, and fix them in another PR, as discussed in #455

@jens1o jens1o merged commit 6c76ffa into PHP-FFMpeg:v1.x Dec 16, 2017
@jens1o
Copy link
Member

jens1o commented Dec 16, 2017

Thank you. :)

@carusogabriel carusogabriel deleted the fix-mocks-tests branch December 16, 2017 07:31
@carusogabriel carusogabriel mentioned this pull request Dec 16, 2017
Merged
@jens1o jens1o added this to the 1.x milestone Dec 16, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jens1o jens1o jens1o approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.x
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@carusogabriel @jens1o