Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Expect Exception tests #459

Merged
merged 1 commit into from
Dec 16, 2017
Merged

Fix Expect Exception tests #459

merged 1 commit into from
Dec 16, 2017

Conversation

carusogabriel
Copy link
Contributor

Q A
Bug fix? Yes
New feature? no
BC breaks? Yes
Deprecations? Yes
Fixed tickets #412
Related issues/PRs #412 #455 #458
License MIT

As suggested in #455, let's fix the tests step by step. Second:

  • Use expectException and expectExceptionMessage instead of setExpectedException, as it doesn't exist in PHPUnit 6 anymore.

@jens1o jens1o merged commit d261100 into PHP-FFMpeg:v1.x Dec 16, 2017
@jens1o
Copy link
Member

jens1o commented Dec 16, 2017

awesome :)

@jens1o jens1o added this to the 1.x milestone Dec 16, 2017
@carusogabriel carusogabriel deleted the fix-expect-exception branch December 16, 2017 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.x
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@carusogabriel @jens1o