Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the PHPCSDev ruleset #29

Merged
merged 1 commit into from
Feb 12, 2020
Merged

Remove the PHPCSDev ruleset #29

merged 1 commit into from
Feb 12, 2020

Conversation

jrfnl
Copy link
Member

@jrfnl jrfnl commented Feb 12, 2020

The PHPCSDev ruleset has a different PHPCS requirement from the other tooling in this repo, making it an awkward fit.

With that in mind, the ruleset has been moved to a separate repository PHPCSDevCS.

This now removes it from PHPCSDevtools.

Includes:

  • Adding PHPCSDevCS as a dev dependency for this repo.

The `PHPCSDev` ruleset has a different PHPCS requirement from the other tooling in this repo, making it an awkward fit.

With that in mind, the ruleset has been moved to a separate repository [`PHPCSDevCS`](https://github.com/PHPCSStandards/PHPCSDevCS).

This now removes it from PHPCSDevtools.

Includes:
* Adding `PHPCSDevCS` as a `dev` dependency for this repo.
@jrfnl jrfnl added this to the 1.0.0 milestone Feb 12, 2020
@jrfnl jrfnl changed the title 🚫 Remove the PHPCSDev ruleset Remove the PHPCSDev ruleset Feb 12, 2020
@jrfnl jrfnl merged commit b1af253 into develop Feb 12, 2020
@jrfnl jrfnl deleted the feature/remove-dev-ruleset branch February 12, 2020 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant