PHPCSDebug/Tests: change set up #46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrfnl
force-pushed
the
feature/make-tests-stable
branch
from
04505f6
to
34d0bed
Compare
Change the test setup from being based on the test suite in PHPCS to using the PHPCSUtils `UtilityMethodTestCase` as a basis.
That should stabilize the test, as well as allow the test to run without problems on higher PHPUnit/PHP versions.
### Added:
* Composer:
- Dev dependency on PHPCSUtils. Only needed for running the tests.
Does - for now - require a minimum stability of `dev` though.
- A wider range of PHPUnit versions as the PHPCSUtils test case is compatible with these.
* Test bootstrap:
- Define some PHPCS constants which are expected for the test run.
- Loading of the PHPCSUtils autoload file.
To run the tests locally using git clones instead of a Composer setup, make sure to set a `PHPCSUTILS_DIR` environment variable pointing to the clone of PHPCSUtils.
- Loading of the PHPCS native `Tokens` class to prevent issues with tokens not being defined.
### Changed:
* Composer:
- Raise the minimum PHPCS requirement to `3.1.0` as otherwise it would conflict with PHPCSUtils.
⚠️ This needs a changelog entry : warning:
- Remove the arguments for the PHPUnit script. These are no longer needed.
* Tests: Merged the two test files for the one sniff into one file using the `UtilityMethodTestCase` as a base instead of the PHPCS native `AbstractSniffUnitTest`.
### Removed:
* Travis: all PHPUnit versions are now unconditionally supported. PHPUnit support no longer depends on which PHPCS version is installed.
* Travis: PHPCS 4.x does not need to be installed using `--prefer-source` anymore as we're no longer using the PHPCS native test case basis.
* Test bootstrap: the setting of the `PHPCS_IGNORE_TEST` environment variable as it is no longer needed (PHPCS test setup specific).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change the test setup from being based on the test suite in PHPCS to using the PHPCSUtils
UtilityMethodTestCaseas a basis.That should stabilize the test, as well as allow the test to run without problems on higher PHPUnit/PHP versions.
Added:
Does - for now - require a minimum stability of
devthough.To run the tests locally using git clones instead of a Composer setup, make sure to set a
PHPCSUTILS_DIRenvironment variable pointing to the clone of PHPCSUtils.Tokensclass to prevent issues with tokens not being defined.Changed:
3.1.0as otherwise it would conflict with PHPCSUtils.UtilityMethodTestCaseas a base instead of the PHPCS nativeAbstractSniffUnitTest.Removed:
--prefer-sourceanymore as we're no longer using the PHPCS native test case basis.PHPCS_IGNORE_TESTenvironment variable as it is no longer needed (PHPCS test setup specific).