CI: switch to GitHub Actions #51
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit:
* Adds a GH Actions workflow for the CI checks which were previously run on Travis in the `sniff` stage.
While these aren't 100% CS (= code style) checks, for the badge and workflow display, `CS` still seemed the most descriptive name.
* Removes that part of the `.travis.yml` configuration.
* Adds a "Build Status" badge in the Readme to use the results from this particular GH Actions runs.
Notes:
Builds will run on all pushes and on pull requests, with the exception of those just modifying files which are irrelevant to this workflow.
jrfnl
force-pushed
the
feature/move-to-gh-actions
branch
from
a07c6e7
to
4f58b98
Compare
This commit:
* Adds a GH Actions workflow for the CI checks which were previously run on Travis in the `quicktest` stage.
* Removes that part of the `.travis.yml` configuration.
Notes:
1. Previously, this "stage" would run on all `push` events, except when merging to `master` or `develop`.
The current set-up still does so, with one exception: pushes to `develop` will now use this quicktest instead of the full test.
`develop` is a protected branch anyhow, so all merges will already have had the full test run in the pull request.
For merges to `master`, the full Test will still be used as that will generally mean we're getting ready to tag a release and some extra safety checking before a release is not a bad thing.
2. This also updates the "high" PHP version for the "quicktest" against PHPCS `dev-master` from PHP 7.4 to PHP 8.0 by using `latest` which translates to "latest stable PHP release".
This commit:
* Adds a GH Actions workflow for the CI checks which were previously run on Travis in the `test` stage.
* Removes the, now redundant, `.travis.yml` configuration.
* Updates the `.gitattributes` file.
* Adds a "Build Status" badge in the Readme to use the results from the GH `Test` Actions runs and removes the old badges.
* Updates the "Tested on" badge.
Notes:
1. Previously, this "stage" would run on all `pull requests` events.
The current set-up still does so, with one addition: pushes to `master` (merges) will now also use this workflow instead of the quicktest.
This replaces the full run on tagging a release, meaning that thing will essentially be the same.
2. As there are a couple of jobs which are "allowed to fail" (`experimental` = true), the build status will unfortunately show as "failed", even though all non-experimental jobs have succeeded.
This is a known issue in GHA: https://github.com/actions/toolkit/issues/399
jrfnl
force-pushed
the
feature/move-to-gh-actions
branch
from
4f58b98
to
764203a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CI: switch to GitHub Actions - step 1: sniff stage
This commit:
sniffstage.While these aren't 100% CS (= code style) checks, for the badge and workflow display,
CSstill seemed the most descriptive name..travis.ymlconfiguration.Notes:
Builds will run on all pushes and on pull requests, with the exception of those just modifying files which are irrelevant to this workflow.
CI: switch to GitHub Actions - step 2: quick test stage
This commit:
quickteststage..travis.ymlconfiguration.Notes:
pushevents, except when merging tomasterordevelop.The current set-up still does so, with one exception: pushes to
developwill now use this quicktest instead of the full test.developis a protected branch anyhow, so all merges will already have had the full test run in the pull request.For merges to
master, the full Test will still be used as that will generally mean we're getting ready to tag a release and some extra safety checking before a release is not a bad thing.dev-masterfrom PHP 7.4 to PHP 8.0 by usinglatestwhich translates to "latest stable PHP release".CI: switch to GitHub Actions - step 3: test and coverage stage
This commit:
teststage..travis.ymlconfiguration..gitattributesfile.TestActions runs and removes the old badges.Notes:
pull requestsevents.The current set-up still does so, with one addition: pushes to
master(merges) will now also use this workflow instead of the quicktest.This replaces the full run on tagging a release, meaning that thing will essentially be the same.
experimental= true), the build status may show as "failed", even though all non-experimental jobs have succeeded.This is a known issue in GHA: Please support something like "allow-failure" for a given job actions/runner#2347