Merge pull request #114 from PHPCSStandards/feature/universal.classes…

….disallowfinalclass-bugfix-metrics Classes/DisallowFinalClassSniff: fix incorrect recording of metrics
PHPCSStandards · May 6, 2022 · 7793726 · 7793726
2 parents 7491842 + cfca53a
commit 7793726
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/Universal/Sniffs/Classes/DisallowFinalClassSniff.php b/Universal/Sniffs/Classes/DisallowFinalClassSniff.php
@@ -56,11 +56,11 @@ public function process(File $phpcsFile, $stackPtr)
          */
         $classProp = BCFile::getClassProperties($phpcsFile, $stackPtr);
         if ($classProp['is_final'] === false) {
-            if ($classProp['is_abstract'] === false) {
+            if ($classProp['is_abstract'] === true) {
                 $phpcsFile->recordMetric($stackPtr, 'Class declaration type', 'abstract');
             }
 
-            $phpcsFile->recordMetric($stackPtr, 'Class declaration type', 'final');
+            $phpcsFile->recordMetric($stackPtr, 'Class declaration type', 'not abstract, not final');
             return;
         }
 
@@ -70,7 +70,7 @@ public function process(File $phpcsFile, $stackPtr)
             return;
         }
 
-        $phpcsFile->recordMetric($stackPtr, 'Class declaration type', 'not abstract, not final');
+        $phpcsFile->recordMetric($stackPtr, 'Class declaration type', 'final');
 
         // No extra safeguards needed, we know the keyword will exist based on the check above.
         $finalKeyword = $phpcsFile->findPrevious(\T_FINAL, ($stackPtr - 1));