Merge pull request #136 from PHPCSStandards/universal/disallowstandal…

…onepostincdec-use-objoperators-method DisallowStandalonePostIncrementDecrement: prevent looking for nullsafe object operator
PHPCSStandards · Oct 25, 2022 · 7e1cae2 · 7e1cae2
2 parents 6c59982 + b74734d
commit 7e1cae2
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 0 deletions.
diff --git a/Universal/Sniffs/Operators/DisallowStandalonePostIncrementDecrementSniff.php b/Universal/Sniffs/Operators/DisallowStandalonePostIncrementDecrementSniff.php
@@ -57,6 +57,12 @@ public function register()
         $this->allowedTokens += Collections::objectOperators();
         $this->allowedTokens += Collections::namespacedNameTokens();
 
+        /*
+         * Remove potential nullsafe object operator. In/decrement not allowed in write context,
+         * so ignore.
+         */
+        unset($this->allowedTokens[\T_NULLSAFE_OBJECT_OPERATOR]);
+
         return Collections::incrementDecrementOperators();
     }
 

diff --git a/Universal/Tests/Operators/DisallowStandalonePostIncrementDecrementUnitTest.inc b/Universal/Tests/Operators/DisallowStandalonePostIncrementDecrementUnitTest.inc
@@ -70,5 +70,8 @@ $a = 10 + $i++ - 5;
 
 return $a['key'][$i++];
 
+// Intentional parse error. Nullsafe operator not allowed in write-context. Ignore.
+$obj?->prop++;
+
 // Intentional parse error.
 ++;
diff --git a/Universal/Tests/Operators/DisallowStandalonePostIncrementDecrementUnitTest.inc.fixed b/Universal/Tests/Operators/DisallowStandalonePostIncrementDecrementUnitTest.inc.fixed
@@ -70,5 +70,8 @@ $a = 10 + $i++ - 5;
 
 return $a['key'][$i++];
 
+// Intentional parse error. Nullsafe operator not allowed in write-context. Ignore.
+$obj?->prop++;
+
 // Intentional parse error.
 ++;