Skip to content

Commit

Permalink
GH Actions: minor tweaks
Browse files Browse the repository at this point in the history
* The `--ignore-platform-req=php+` is no longer needed now PHPUnit 8 and 9 are supported (since PR 299 / PHPCS 3.8.0).
* Minor readability improvement of the script snippet.
  • Loading branch information
jrfnl committed Feb 16, 2024
1 parent 11d387c commit f323022
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 6 deletions.
5 changes: 3 additions & 2 deletions .github/workflows/quicktest.yml
Original file line number Diff line number Diff line change
Expand Up @@ -70,8 +70,9 @@ jobs:
- name: "Composer: set PHPCS/PHPCSUtils version for tests (lowest)"
if: ${{ matrix.phpcs_version == 'lowest' }}
run: >
composer update squizlabs/php_codesniffer phpcsstandards/phpcsutils
--prefer-lowest --ignore-platform-req=php+ --no-scripts --no-interaction
composer update --prefer-lowest --no-scripts --no-interaction
squizlabs/php_codesniffer
phpcsstandards/phpcsutils
- name: Lint against parse errors
if: matrix.phpcs_version == 'dev-master'
Expand Down
10 changes: 6 additions & 4 deletions .github/workflows/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -76,8 +76,9 @@ jobs:
- name: "Composer: set PHPCS/PHPCSUtils version for tests (lowest)"
if: ${{ matrix.phpcs_version == 'lowest' }}
run: >
composer update squizlabs/php_codesniffer phpcsstandards/phpcsutils
--prefer-lowest --ignore-platform-req=php+ --no-scripts --no-interaction
composer update --prefer-lowest --no-scripts --no-interaction
squizlabs/php_codesniffer
phpcsstandards/phpcsutils
- name: Lint against parse errors
if: matrix.phpcs_version == 'dev-master'
Expand Down Expand Up @@ -143,8 +144,9 @@ jobs:
- name: "Composer: set PHPCS/PHPCSUtils version for tests (lowest)"
if: ${{ matrix.phpcs_version == 'lowest' }}
run: >
composer update squizlabs/php_codesniffer phpcsstandards/phpcsutils
--prefer-lowest --ignore-platform-req=php+ --no-scripts --no-interaction
composer update --prefer-lowest --no-scripts --no-interaction
squizlabs/php_codesniffer
phpcsstandards/phpcsutils
- name: Lint against parse errors
if: matrix.phpcs_version == 'dev-master'
Expand Down

0 comments on commit f323022

Please sign in to comment.