New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

QA: make all classes `final` #121

Merged

jrfnl merged 1 commit into develop from feature/qa-all-classes-should-be-final

Jul 22, 2022

Member

jrfnl commented Jul 22, 2022

Sniffs extending other sniffs which are not explicitly abstract is not a good idea and can lead to problems with the sniff autoloading.

By making all sniffs in the package final, that problem should be prevented.


          QA: make all classes final

4f53913

jrfnl added the Type: chores/QA label

jrfnl added this to the 1.0.0-alpha4 milestone

jrfnl enabled auto-merge

July 22, 2022 21:36

jrfnl merged commit 0abedcc into develop

jrfnl deleted the feature/qa-all-classes-should-be-final branch

July 22, 2022 21:40

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment