Universal/PrecisionAlignment: bug fix - improved handling of heredoc/nowdoc closers #124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…/nowdoc closers
This commit fixes two bugs:
1. When a heredoc/nowdoc closer (PHP 7.3+ flexible syntax) is indented with tabs, PHPCS does not replace tabs with spaces in the token.
This means the token `'length'` key will also be tab-based, which leads to incorrrect calculations and false positives with incorrect fixes.
Fixed now by handling tab replacement in heredoc/nowdoc closer tokens in the sniff itself.
2. A heredoc/nowdoc closer using flexible syntax is not allowed to have a larger indent than any of the content of the heredoc/nowdoc. Doing so results in a parse error.
With the "best guess" rounding of the indent, the sniff had a risk of introducing these kind of parse errors.
Fixed now by always rounding the expected indent down to the nearest tabstop for these tokens.
Includes additional unit tests to cover the changes.
jrfnl
deleted the
universal/whitespace-precisionalignment-bugfix-flexible-heredoc-nowdoc
branch
jrfnl
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes two bugs:
This means the token
'length'key will also be tab-based, which leads to incorrrect calculations and false positives with incorrect fixes.Fixed now by handling tab replacement in heredoc/nowdoc closer tokens in the sniff itself.
With the "best guess" rounding of the indent, the sniff had a risk of introducing these kind of parse errors.
Fixed now by always rounding the expected indent down to the nearest tabstop for these tokens.
Includes additional unit tests to cover the changes.