Universal/DisallowShortListSyntax: allow for tokenizer issue in PHPCS 3.7.1 #151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… 3.7.1 ... which was fixed in 3.7.2. The utility methods used from PHPCSUtils 1.0.0-alpha4 already take this into account, so this should be handled without problems. Includes test. Ref: * squizlabs/PHP_CodeSniffer 3632 * PHPCSStandards/PHPCSUtils 392
jrfnl
deleted the
universal/disallowshortlistsyntax-fix-phpcs-x-version-bug
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... which was fixed in 3.7.2.
The utility methods used from PHPCSUtils 1.0.0-alpha4 already take this into account, so this should be handled without problems.
Includes test.
Ref: