Universal/DisallowAlternativeSyntax: improve error message #159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the `$allowWithInlineHTML` property is set to `true`, the error message could be regarded as confusing and lead to (unfounded) bug reports as the error message doesn't indicate that alternative control structures, in that case, are still allowed in combination with inline HTML. This commit adjusts the error message based on the `$allowWithInlineHTML` property to be more descriptive.
Improve the readability of the error message by moving the variable part to the end of the message.
Group the setting of the `$code` and `$data` variables for the error message with the conditions which may adjust their value.
jrfnl
force-pushed
the
universal/disallowalternativesyntax-improve-error-message
branch
from
674650e
to
dfc686e
Compare
jrfnl
deleted the
universal/disallowalternativesyntax-improve-error-message
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Universal/DisallowAlternativeSyntax: improve the error message [1]
When the
$allowWithInlineHTMLproperty is set totrue, the error message could be regarded as confusing and lead to (unfounded) bug reports as the error message doesn't indicate that alternative control structures, in that case, are still allowed in combination with inline HTML.This commit adjusts the error message based on the
$allowWithInlineHTMLproperty to be more descriptive.Universal/DisallowAlternativeSyntax: improve the error message [2]
Improve the readability of the error message by moving the variable part to the end of the message.
Universal/DisallowAlternativeSyntax: minor tweak
Group the setting of the
$codeand$datavariables for the error message with the conditions which may adjust their value.