Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Universal/DisallowLonelyIf: add extra test #168

Merged
merged 1 commit into from
Dec 1, 2022
Merged

Universal/DisallowLonelyIf: add extra test #168

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions Universal/Tests/ControlStructures/DisallowLonelyIfUnitTest.inc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -265,6 +265,19 @@ if ($a) {
}
}

/*
* Inner block mixing conditions with and without curly braces (which is perfectly valid in PHP).
* Bow out as it cannot be determined reliably whether there is something behind the last condition.
*/
if ($condition) {
doSomething();
} else {
if ($anotherCondition) {
doSomething();
} else if ($secondIf)
doSomething();
}

// Live coding.
// Intentional parse error. This test has to be the last in the file.
if ($a) {
Expand Down
13 changes: 13 additions & 0 deletions Universal/Tests/ControlStructures/DisallowLonelyIfUnitTest.inc.fixed
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -240,6 +240,19 @@ if ($a) {
}
}

/*
* Inner block mixing conditions with and without curly braces (which is perfectly valid in PHP).
* Bow out as it cannot be determined reliably whether there is something behind the last condition.
*/
if ($condition) {
doSomething();
} else {
if ($anotherCondition) {
doSomething();
} else if ($secondIf)
doSomething();
}

// Live coding.
// Intentional parse error. This test has to be the last in the file.
if ($a) {
Expand Down