Universal/DisallowLonelyIf: bow out early for a specific situation (PHP close tag) #169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…HP close tag) If an inner "if/else" chain using alternative syntax has a PHP close tag after the `endif` instead of a semi-colon, we **know** there will need to be a PHP open tag before the closer for the "outer" `else` can be reached, so this means there will always be additional content within the outer `else` which doesn't belong with the inner `if`, i.e. it's not a lonely `if`. This commit implements bowing out early for that situation. Includes unit test. Includes minor tweaks to the inline documentation to make it clearer that the `do-while` code is part of the "Find the end of an if - else chain." block.
jrfnl
deleted the
universal/disallowlonelyif-bow-out-early-for-close-tag
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If an inner "if/else" chain using alternative syntax has a PHP close tag after the
endifinstead of a semi-colon, we know there will need to be a PHP open tag before the closer for the "outer"elsecan be reached, so this means there will always be additional content within the outerelsewhich doesn't belong with the innerif, i.e. it's not a lonelyif.This commit implements bowing out early for that situation.
Includes unit test.
Includes minor tweaks to the inline documentation to make it clearer that the
do-whilecode is part of the "Find the end of an if - else chain." block.