Universal/DisallowInlineTabs: add extra tests + remove redundancy #217
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrfnl
force-pushed
the
universal/disallowinlinetabs-add-extra-tests
branch
2 times, most recently
from
bcfb9e1
to
8d4327b
Compare
* Add a space-based test case file which shouldn't yield any errors or warnings at all. * Make sure that the "tabwidth" set for test files is correctly respected. * Fix the `DisallowInlineTabsUnitTest.5.inc` fixed file.
jrfnl
force-pushed
the
universal/disallowinlinetabs-add-extra-tests
branch
from
5fd97bc
to
19bc003
Compare
The `'orig_content'` key only gets set when there are tabs in the token content, so no need for the extra check.
jrfnl
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Universal/DisallowInlineTabs: add extra tests + fix test tab handling
DisallowInlineTabsUnitTest.5.incfixed file.Universal/DisallowInlineTabs: remove some redundant code
The
'orig_content'key only gets set when there are tabs in the token content, so no need for the extra check.