Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modernize/Dirname: respect a passed php_version #261

Merged
merged 2 commits into from
Aug 9, 2023
Merged

Modernize/Dirname: respect a passed php_version #261

merged 2 commits into from
Aug 9, 2023

Commits on Aug 9, 2023

  1. Modernize/Dirname: rename test case file 

    ... in anticipation of additional test case files being added.
    @jrfnl
    jrfnl committed Aug 9, 2023
    Configuration menu
    Copy the full SHA
    2fea560 View commit details
    Browse the repository at this point in the history

  2. Modernize/Dirname: respect a passed php_version 

    If no `php_version` is passed, the sniff will behave as before.

However, is a `php_version` is passed, the sniff will now selectively stay silent depending on the configured PHP and whether the proposed fixes could be applied.

Includes additional tests.
Includes adding information about the support of the `php_version` config setting to the README docs.
    @jrfnl
    jrfnl committed Aug 9, 2023
    Configuration menu
    Copy the full SHA
    46af321 View commit details
    Browse the repository at this point in the history