Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ New Universal.PHP.LowercasePHPTag sniff #276

Merged
merged 1 commit into from
Nov 12, 2023

Conversation

jrfnl
Copy link
Member

@jrfnl jrfnl commented Sep 21, 2023

... to enforce that the "PHP" in a PHP open tag is lowercase.

Includes fixer.
Includes unit tests.
Includes documentation.
Includes metrics.

Copy link
Member

@fredden fredden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This sniff looks good. I've tested this locally. As far as I can tell, this behaves as expected.
👍

Universal/Sniffs/PHP/LowercasePHPTagSniff.php Outdated Show resolved Hide resolved
... to enforce that the "PHP" in a PHP open tag is lowercase.

Includes fixer.
Includes unit tests.
Includes documentation.
Includes metrics.
@jrfnl jrfnl force-pushed the universal/new-lowercase-php-tag-sniff branch from 78fe6ad to 64db8a3 Compare October 4, 2023 23:57
Copy link
Member

@fredden fredden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-reviewed and tested locally.

@jrfnl jrfnl merged commit 8b52fe3 into develop Nov 12, 2023
39 checks passed
@jrfnl jrfnl deleted the universal/new-lowercase-php-tag-sniff branch November 12, 2023 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants