New Universal.Arrays.DisallowShortArraySyntax sniff
#40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The upstream PHPCS `Generic.Arrays.DisallowShortArraySyntax` sniff does not account for short lists and will cause parse errors during auto-fixing when these are encountered. As the utilities from PHPCSUtils were never merged into PHPCS itself, fixing it upstream would be tedious and would involve duplicating more code than I care to. So instead, this duplicates the sniff, including the fix which was originally contained in the Refactor branch as pulled to PHPCS. Includes fixer. Includes unit tests. Includes documentation. Co-authored-by: Greg Sherwood <gsherwood@squiz.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The upstream PHPCS
Generic.Arrays.DisallowShortArraySyntaxsniff does not account for short lists and will cause parse errors during auto-fixing when these are encountered.As the utilities from PHPCSUtils were never merged into PHPCS itself, fixing it upstream would be tedious and would involve duplicating more code than I care to.
So instead, this duplicates the sniff, including the fix which was originally contained in the Refactor branch as pulled to PHPCS.
Includes fixer.
Includes unit tests.
Includes documentation.