ADD TO: implement

PHPCSStandards · Jun 30, 2022 · 4095888 · 4095888
1 parent 9f5aeea
commit 4095888
Show file tree

Hide file tree

Showing 2 changed files with 36 additions and 1 deletion.
diff --git a/Tests/Utils/Namespaces/DetermineNamespaceTest.php b/Tests/Utils/Namespaces/DetermineNamespaceTest.php
@@ -10,6 +10,7 @@
 
 namespace PHPCSUtils\Tests\Utils\Namespaces;
 
+use PHPCSUtils\Internal\Cache;
 use PHPCSUtils\TestUtils\UtilityMethodTestCase;
 use PHPCSUtils\Utils\Namespaces;
 
@@ -189,6 +190,40 @@ public function dataDetermineNamespace()
         ];
     }
 
+    /**
+     * Verify that the build-in caching is used when caching is enabled.
+     *
+     * @return void
+     */
+    public function testFindNamespacePtrResultIsCached()
+    {
+        // The test case used is specifically selected to be one which will always reach the cache check.
+        $methodName = 'PHPCSUtils\\Utils\\Namespaces::findNamespacePtr';
+        $cases      = $this->dataDetermineNamespace();
+        $testMarker = $cases['non-scoped-namespace-2']['testMarker'];
+        $expected   = $cases['non-scoped-namespace-2']['expected']['ptr'];
+
+        $stackPtr = $this->getTargetToken($testMarker, \T_ECHO);
+        $expected = $this->getTargetToken($expected, \T_NAMESPACE);
+
+        // Verify the caching works.
+        $origStatus     = Cache::$enabled;
+        Cache::$enabled = true;
+
+        $resultFirstRun  = Namespaces::findNamespacePtr(self::$phpcsFile, $stackPtr);
+        $isCached        = Cache::isCached(self::$phpcsFile, $methodName, $stackPtr);
+        $resultSecondRun = Namespaces::findNamespacePtr(self::$phpcsFile, $stackPtr);
+
+        if ($origStatus === false) {
+            Cache::clear();
+        }
+        Cache::$enabled = $origStatus;
+
+        $this->assertSame($expected, $resultFirstRun, 'First result did not match expectation');
+        $this->assertTrue($isCached, 'Cache::isCached() could not find the cached value');
+        $this->assertSame($resultFirstRun, $resultSecondRun, 'Second result did not match first');
+    }
+
     /**
      * Test that the namespace declaration itself is not regarded as being namespaced.
      *

diff --git a/Tests/Utils/PassedParameters/GetParametersTest.php b/Tests/Utils/PassedParameters/GetParametersTest.php
@@ -550,7 +550,7 @@ public function test( $foo, $bar ) {
      *
      * @return void
      */
-    public function testResultIsCached()
+    public function testGetParametersResultIsCached()
     {
         // The test case used is specifically selected as the raw and the clean param values will be the same.
         $methodName = 'PHPCSUtils\\Utils\\PassedParameters::getParameters';