Merge pull request #361 from PHPCSStandards/php-8.1/document-support-…

…for-named-params-after-arg-unpacking PHP 8.1 | PassedParameters::getParameters(): document test with named params after argument unpacking
PHPCSStandards · Oct 15, 2022 · 81d22d0 · 81d22d0
2 parents b1a4889 + 190a5e5
commit 81d22d0
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 4 deletions.
diff --git a/Tests/Utils/PassedParameters/GetParametersNamedTest.inc b/Tests/Utils/PassedParameters/GetParametersNamedTest.inc
@@ -65,8 +65,8 @@ test(param: 1, param: 2);
 // Error Exception, but not the concern of PHPCSUtils. Should still be handled.
 array_fill(start_index: 0, ...[100, 50]);
 
-/* testCompileErrorIncorrectOrderWithVariadic */
-// Not the concern of PHPCSUtils. Should still be handled.
+/* testPHP81NamedParamAfterVariadic */
+// Prior to PHP 8.1, this was a compile error, but this is now supported.
 test(...$values, param: $value);
 
 /* testParseErrorNoValue */

diff --git a/Tests/Utils/PassedParameters/GetParametersNamedTest.php b/Tests/Utils/PassedParameters/GetParametersNamedTest.php
@@ -519,8 +519,9 @@ public function dataGetParameters()
                     ],
                 ],
             ],
-            'named-args-compile-error-incorrect-order-variadic' => [
-                'testMarker' => '/* testCompileErrorIncorrectOrderWithVariadic */',
+            // Prior to PHP 8.1, this was a compile error, but this is now supported.
+            'named-args-after-variadic' => [
+                'testMarker' => '/* testPHP81NamedParamAfterVariadic */',
                 'targetType' => \T_STRING,
                 'expected'   => [
                     1 => [