Travis: test on nightly #164
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Up to now, the DealerDirect plugin was a blocker for testing the standard against PHP `nightly`/ PHP 8 as it would refuse to install. With the new version having been tagged, this issue has been removed, so we can now run the unit tests against PHP 8 to get early warning about cross-version compatibility issues which need fixing. We still need to use `--ignore-platform-reqs` for PHPUnit as PHPUnit 9 does not (yet) allow for PHP 8, though this is expected to be sorted in v9.3 (expected August). The builds against `nightly` remain in `allow_failures` for now. Refs: * https://github.com/Dealerdirect/phpcodesniffer-composer-installer/releases/tag/v0.7.0
jrfnl
force-pushed
the
feature/travis-test-on-nightly
branch
from
521bd43
to
fdabd4a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Up to now, the DealerDirect plugin was a blocker for testing the standard against PHP
nightly/ PHP 8 as it would refuse to install.With the new version having been tagged, this issue has been removed, so we can now run the unit tests against PHP 8 to get early warning about cross-version compatibility issues which need fixing.
We still need to use
--ignore-platform-reqsfor PHPUnit as PHPUnit 9 does not (yet) allow for PHP 8, though this is expected to be sorted in v9.3 (expected August).The builds against
nightlyremain inallow_failuresfor now.Refs: