Conversation
…ame tokens Includes adjusted unit test. This commit implicitly adds support for PHP 8 identifier name tokens to the `Variables::getMemberProperties()` method. The existing unit tests already cover this. This commit also _silently_ adds support for PHP 8 identifier name tokens to the `BCFile::getMemberProperties()` method. The PHP 8 identifier name tokens are not supported yet in PHPCS itself and until they are, the fact that the `BCFile::getMemberProperties()` method supports them should be regarded as an artefact and not as official support.
jrfnl
deleted the
php-8.0/collections-propertytypetokens-support-identifier-name-tokens
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Includes adjusted unit test.
This commit implicitly adds support for PHP 8 identifier name tokens to the
Variables::getMemberProperties()method.The existing unit tests already cover this.
This commit also silently adds support for PHP 8 identifier name tokens to the
BCFile::getMemberProperties()method. The PHP 8 identifier name tokens are not supported yet in PHPCS itself and until they are, the fact that theBCFile::getMemberProperties()method supports them should be regarded as an artifact and not as official support.