Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PassedParameters::hasParameters(): compatibility with the PHP 8 identifier name tokenization #211

Merged
merged 1 commit into from
Sep 13, 2020
Merged

PassedParameters::hasParameters(): compatibility with the PHP 8 identifier name tokenization #211

merged 1 commit into from
Sep 13, 2020

Commits on Sep 13, 2020

  1. PassedParameters::hasParameters(): compatibility with the PHP 8 ident… 

    …ifier name tokenization

The `PassedParameters::hasParameters()` does a token based check on whether or not the passed token is one which is handled by this method, as well as the other methods in this class.

That check now needs to take the PHP 8 identifier name tokens into account and should treat them as the same as `T_STRING`, i.e. as as suspected function call.

This commit adjusts the `PassedParameters::hasParameters()` method to allow for these new tokens.

Includes additional unit tests covering the different tokens.
    @jrfnl
    jrfnl committed Sep 13, 2020
    Configuration menu
    Copy the full SHA
    6d5ab56 View commit details
    Browse the repository at this point in the history