Conversation
Upstream PR 3063 which was merged in PHPCS 3.5.7 effectively "undoes" the PHP 8.0 tokenization for identifier names for PHPCS 3.x, while it also includes backfilling the PHP 8.0 token constants. In PHPCS 4.x the PHP 8.0 tokenization will be backfilled instead, but that PR has not yet been pulled. This commit annotates the current change in the `Collections::nameTokens()` method and updates the unit tests for various token collections to handle this correctly as well. Refs: * squizlabs/PHP_CodeSniffer#3041 * squizlabs/PHP_CodeSniffer#3063
jrfnl
force-pushed
the
collections/sync-with-phpcs-3.x-identifier-names
branch
from
afc6674 to
91f2250
Compare
…ndoing" the PHP 8.0 identifier name tokenization Upstream PR 3063 which was merged in PHPCS 3.5.7 effectively "undoes" the PHP 8.0 tokenization for identifier names for PHPCS 3.x. This updates the `UtilityMethodTestCase::usesPhp8NameTokens()` method to take this upstream change into account.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Collections/various methods: sync with PHPCS
Upstream PR squizlabs/PHP_CodeSniffer#3063 which was merged for PHPCS 3.5.7 effectively "undoes" the PHP 8.0 tokenization for identifier names for PHPCS 3.x, while it also includes backfilling the PHP 8.0 token constants.
In PHPCS 4.x the PHP 8.0 tokenization will be backfilled instead.
This commit annotates this change in the
Collections::nameTokens()method and updates the unit tests for various token collections to handle this correctly as well.Refs:
UtilityMethodTestCase::usesPhp8NameTokens(): account for PHPCS 3.x "undoing" the PHP 8.0 identifier name tokenization
Upstream PR #3063 which was merged in PHPCS 3.5.7 effectively "undoes" the PHP 8.0 tokenization for identifier names for PHPCS 3.x.
This updates the
UtilityMethodTestCase::usesPhp8NameTokens()method to take this upstream change into account.