Conversation
jrfnl
force-pushed
the
collections/sync-with-phpcs-4.x-identifier-names
branch
2 times, most recently
from
a40b929 to
3b9adba
Compare
Upstream PR 3155 for PHPCS 4.x backfills the PHP 8.0 tokenization for identifier names for older PHP versions, including backfilling the PHP 8.0 token constants. This commit updates the unit tests for various token collections to handle this correctly. Refs: * squizlabs/PHP_CodeSniffer 3041 * squizlabs/PHP_CodeSniffer 3155
…ckfilling the PHP 8.0 identifier name tokenization Upstream PR 3155 for PHPCS 4.x backfills the PHP 8.0 tokenization for identifier names for older PHP versions. This updates the `UtilityMethodTestCase::usesPhp8NameTokens()` method to take this upstream change into account.
jrfnl
force-pushed
the
collections/sync-with-phpcs-4.x-identifier-names
branch
from
3b9adba to
22c1d49
Compare
… added in PHPCS 4.x Upstream PR 3155 for PHPCS 4.x adds the PHP 8.0 tokens for identifier names to the `Tokens::$functionNameTokens` property. This updates the `BCTokens::functionNameTokens()` method to take this upstream change into account. Includes unit tests.
* One test didn't yet take PHP 8 identifier names into account. * The other did, but contained a typo/count error.
jrfnl
force-pushed
the
collections/sync-with-phpcs-4.x-identifier-names
branch
from
22c1d49 to
5c69cbb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PHPCS 4.x | Collections/various methods: sync with PHPCS
Upstream PR squizlabs/PHP_CodeSniffer#3155 for PHPCS 4.x backfills the PHP 8.0 tokenization for identifier names for older PHP versions, including backfilling the PHP 8.0 token constants.
This commit updates the unit tests for various token collections to handle this correctly.
Refs:
UtilityMethodTestCase::usesPhp8NameTokens(): account for PHPCS 4.x backfilling the PHP 8.0 identifier name tokenization
Upstream PR squizlabs/PHP_CodeSniffer#3155 for PHPCS 4.x backfills the PHP 8.0 tokenization for identifier names for older PHP versions.
This updates the
UtilityMethodTestCase::usesPhp8NameTokens()method to take this upstream change into account.BCTokens::functionNameTokens(): account for identifier name tokens as added in PHPCS 4.x
Upstream PR squizlabs/PHP_CodeSniffer#3155 for PHPCS 4.x adds the PHP 8.0 tokens for identifier names to the
Tokens::$functionNameTokensproperty.This updates the
BCTokens::functionNameTokens()method to take this upstream change into account.Includes unit tests.
Tests: fix two tests for PHP 8 identifier names
Note: the remaining two test failures on the PHPCS 4.x branch are related to a bug upstream - see PR squizlabs/PHP_CodeSniffer#3104