PHPCS 4.x | Handle closure use being a parenthesis owner#251
Merged
Conversation
`T_USE` tokens used for closure use statements are parentheses owners as of PHPCS 4.x. So, as of PHPCS 4.x, checking for the `parenthesis_owner` index being set is a simpler and more efficient way to determine if a `use` token is a closure use. Refs: * squizlabs/PHP_CodeSniffer 2593 * squizlabs/PHP_CodeSniffer@08824f3 * squizlabs/PHP_CodeSniffer 3104
… owner `T_USE` tokens used for closure use statements are parentheses owners as of PHPCS 4.x. This fixes compatibility of the `BCFile::getMethodParameters()` method with PHPCS 4.x. The existing unit tests already cover this. Refs: * squizlabs/PHP_CodeSniffer 2593 * squizlabs/PHP_CodeSniffer@08824f3 * squizlabs/PHP_CodeSniffer 3104
…dling `T_USE` tokens used for closure use statements are parentheses owners as of PHPCS 4.x. The `FunctionDeclarations::getParameters()` method already handles this correctly cross-version. This just adds documentation to confirm this has been looked at and no changes are needed for cross-version compatibility. Refs: * squizlabs/PHP_CodeSniffer 2593 * squizlabs/PHP_CodeSniffer@08824f3 * squizlabs/PHP_CodeSniffer 3104
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PHPCS 4.x | UseStatements::getType(): efficiency tweak for closure use
T_USEtokens used for closure use statements are parentheses owners as of PHPCS 4.x.So, as of PHPCS 4.x, checking for the
parenthesis_ownerindex being set is a simpler and more efficient way to determine if ausetoken is a closure use.PHPCS 4.x | BCFile::getMethodParameters(): T_USE is now a parenthesis owner
T_USEtokens used for closure use statements are parentheses owners as of PHPCS 4.x.This fixes compatibility of the
BCFile::getMethodParameters()method with PHPCS 4.x.The existing unit tests already cover this.
PHPCS 4.x | FunctionDeclarations::getParameters(): document T_USE handling
T_USEtokens used for closure use statements are parentheses owners as of PHPCS 4.x.The
FunctionDeclarations::getParameters()method already handles this correctly cross-version.This just adds documentation to confirm this has been looked at and no changes are needed for cross-version compatibility.
Refs: