ObjectDeclarations::getClassProperties(): allow for abstract final#252
Merged
jrfnl merged 1 commit intoMay 13, 2021
Merged
Conversation
Having both `abstract` as well as `final` as a modifier for a class is an oxymoron (and a parse error in PHP), but the utility methods should not have an opinion on that. The original `BCFile::getClassProperties()` method already handled this correctly. Now the `ObjectDeclarations::getClassProperties()` method does as well. Includes moving a test from the "diff" test files to the generic test files.
jrfnl
deleted the
feature/objectdeclarations-getclassproperties-allow-for-final
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Having both
abstractas well asfinalas a modifier for a class is an oxymoron (and a parse error in PHP), but the utility methods should not have an opinion on that.The original
BCFile::getClassProperties()method already handled this correctly.Now the
ObjectDeclarations::getClassProperties()method does as well.Includes moving a test from the "diff" test files to the generic test files.
Note: this does potentially make the method slower as it has to search further before deciding it has found all applicable keywords, but that's just how it is.