PassedParameters::getParameters(): add new, optional $limit parameter #261
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds a new, optional `$limit` parameter to the `PassedParameters::getParameters()` method to allow for limiting the number of parameters to be parsed. This allows for higher efficiency when retrieving the parameters/array entries, especially for large arrays if only the first few entries need to be examined. Includes implementing the use of this parameter in the `PassedParameters::getParameter()` method. Includes dedicated unit tests for `PassedParameters::getParameters()` concerning the use of the `$limit` parameter. The change in the `PassedParameters::getParameter()` method is already largely covered by the existing unit tests. Only some extra tests for the use of `$limit` in combination with "named parameters" were needed. Those have been added to the `GetParameterFromStackTest` class. Includes some minor documentation and test function naming improvements to the `GetParameterFromStackTest` class.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a new, optional
$limitparameter to thePassedParameters::getParameters()method to allow for limiting the number of parameters to be parsed.This allows for higher efficiency when retrieving the parameters/array entries, especially for large arrays if only the first few entries need to be examined.
Includes implementing the use of this parameter in the
PassedParameters::getParameter()method.Includes dedicated unit tests for
PassedParameters::getParameters()concerning the use of the$limitparameter.The change in the
PassedParameters::getParameter()method is already largely covered by the existing unit tests.Only some extra tests for the use of
$limitin combination with "named parameters" were needed. Those have been added to theGetParameterFromStackTestclass.Includes some minor documentation and test function naming improvements to the
GetParameterFromStackTestclass.