PassedParameters::hasParameters(): account for upstream tokenization change for parent
#328
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upstream PR squizlabs/PHP_CodeSniffer#3546, which is included in PHPCS 3.7.0, changed the tokenization of the
parent
keyword innew parent()
fromT_STRING
toT_PARENT
.This has consequences for the
PassedParameters::hasParameters()
method and associated methods:Collections::parameterPassingTokens()
method will now need to include theT_PARENT
token.Collections::functionCallTokens()
method should as well.PassedParameters::hasParameters()
method now needs to allow for theT_PARENT
token potentially being used as part of anew parent()
function call.This commit fixes all that up.
Includes additional unit tests to safeguard it all (and some more).