Operators::isUnaryPlusMinus(): allow for match control structures #335
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The double arrow in PHP 8.0 match control structures has its own `T_MATCH_ARROW` token. This token needs to be taken into account when determining if a plus/minus token is unary or arithmetic. This token was introduced in PHPCS 3.6.0 and will be tokenized as `T_DOUBLE_ARROW` for older PHPCS versions. The method already looks for `T_DOUBLE_ARROW` before the operator, so checking for `T_MATCH_ARROW` solely based on token type will handle match arrow tokens in a PHPCS-cross-version compatible manner. Ref: squizlabs/PHP_CodeSniffer 3653 Co-authored-by: Jaroslav Hanslík <kukulich@kukulich.cz>
|
Coveralls is still drunk. Merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Operators::isUnaryPlusMinus(): allow for match control structures
The double arrow in PHP 8.0 match control structures has its own
T_MATCH_ARROWtoken.This token needs to be taken into account when determining if a plus/minus token is unary or arithmetic.
This token was introduced in PHPCS 3.6.0 and will be tokenized as
T_DOUBLE_ARROWfor older PHPCS versions.The method already looks for
T_DOUBLE_ARROWbefore the operator, so checking forT_MATCH_ARROWsolely based on token type will handle match arrow tokens in a PHPCS-cross-version compatible manner.Ref: squizlabs/PHP_CodeSniffer#3653