BCFile::findStartOfStatement(): sync in new tests from upstream + add extra tests #350
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrfnl
force-pushed
the
bctokens/findstartofstatement-sync-with-upstream
branch
from
d5a8e2a
to
81c6e9e
Compare
…tch handling When inside a `switch` `case`/`default` `break`/`continue`/`return`/`exit`/`throw` statement, the start of the statement was not correctly determined. This adds unit tests safeguarding the upstream change. Refs: * squizlabs/php_codesniffer 3192 * squizlabs/PHP_CodeSniffer 3186
jrfnl
force-pushed
the
bctokens/findstartofstatement-sync-with-upstream
branch
from
81c6e9e
to
79c1720
Compare
Refs: * squizlabs/PHP_CodeSniffer@ef80e53 * squizlabs/PHP_CodeSniffer@97f7898 * squizlabs/PHP_CodeSniffer@ae4f33b * squizlabs/PHP_CodeSniffer@faff2f0 * squizlabs/PHP_CodeSniffer@bffe7a5 * squizlabs/PHP_CodeSniffer@3540a5d Co-authored-by: Greg Sherwood <gsherwood@squiz.net>
jrfnl
force-pushed
the
bctokens/findstartofstatement-sync-with-upstream
branch
from
79c1720
to
c4a5f51
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BCFile::findStartOfStatement(): add tests for upstream bugfix for switch handling
When inside a
switchcase/defaultbreak/continue/return/exit/throwstatement, the start of the statement was not correctly determined.This adds unit tests safeguarding the upstream change.
Refs:
BCFile::findStartOfStatement(): sync in new tests from upstream
Refs: