PHP 8.0: add support for match expressions #356
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… array values PHP 8.0 introduced match expressions, which can contain arrays in both the match "case" as well as the match value. Skipping over match expressions will prevent incorrect results for the `Arrays::getDoubleArrowPtr()` method (in particular when a match expression is used as an array key). Includes unit tests. Refs: * https://wiki.php.net/rfc/match_expression_v2
jrfnl
force-pushed
the
php8.0/add-support-for-match-expressions
branch
from
dc61f13
to
c5a9956
Compare
jrfnl
changed the title
…ions PHP 8.0 introduced match expressions as an new control structure. While a `match` expression without body or with an empty body is not allowed and would result in a fatal error (or be interpreted as a non-global function call), the `ControlStructures::hasBody()` method should still handle it correctly. Includes adding the `T_MATCH` token to the `Collections::controlStructureTokens()` token array. Includes unit tests. Refs: * https://wiki.php.net/rfc/match_expression_v2
jrfnl
force-pushed
the
php8.0/add-support-for-match-expressions
branch
from
c5a9956
to
390e964
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PHP 8.0 | Arrays::getDoubleArrowPtr(): allow for match expressions in array values
PHP 8.0 introduced match expressions, which can contain arrays in both the match "case" as well as the match value.
Skipping over match expressions will prevent incorrect results for the
Arrays::getDoubleArrowPtr()method (in particular when a match expression is used as an array key).Includes unit tests.
Refs:
PHP 8.0 | ControlStructures::hasBody(): add support for match expressions
PHP 8.0 introduced match expressions as an new control structure.
While a
matchexpression without body or with an empty body is not allowed and would result in a fatal error (or be interpreted as a non-global function call), theControlStructures::hasBody()method should still handle it correctly.Includes adding the
T_MATCHtoken to theCollections::controlStructureTokens()token array.Includes unit tests.
Refs: