Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FunctionDeclarations::getParameters(): add caching #377

Merged
merged 1 commit into from
Oct 18, 2022
Merged

FunctionDeclarations::getParameters(): add caching #377

merged 1 commit into from
Oct 18, 2022

Commits on Oct 18, 2022

  1. FunctionDeclarations::getParameters(): add caching 

    Follow up on 332

While most function declarations will be quite straight-forward, for function declarations with lots of parameters, this method can be token walking intensive.

As this method is also used by the `Operators::isReference()` method and in the future potentially by yet another method, caching the results of the function seems prudent.

Includes a dedicated test to verify the cache is used and working.
    @jrfnl
    jrfnl committed Oct 18, 2022
    Configuration menu
    Copy the full SHA
    c813643 View commit details
    Browse the repository at this point in the history