Release 1.0.8 #496
Merged
Release 1.0.8 #496
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Various minor docs tweaks
Follow up on PR 468.
Turns out Dependabot PRs do not have access to secrets with the exception of (read-only) access to the `GITHUB_TOKEN`.
As the coverage test runs and the Coveralls status are required builds, this blocks Dependabot PRs from being merged without overruling the required statuses.
As I'd like to avoid that situation, I'm special casing Dependabot PRs for the token selection.
Unfortunately using a condition like `${{ github.actor != 'dependabot[bot]' || secrets.COVERALLS_TOKEN && secrets.GITHUB_TOKEN }}` won't work when it involves secrets, so we need to use duplicate steps to get round this.
Refs:
* lemurheavy/coveralls-public 1721
* https://docs.github.com/en/code-security/dependabot/working-with-dependabot/automating-dependabot-with-github-actions#responding-to-events
…hub-token GH Actions: special case Dependabot PRs for Coveralls
Bumps [actions/upload-pages-artifact](https://github.com/actions/upload-pages-artifact) from 1 to 2. - [Release notes](https://github.com/actions/upload-pages-artifact/releases) - [Commits](actions/upload-pages-artifact@v1...v2) --- updated-dependencies: - dependency-name: actions/upload-pages-artifact dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
…/actions/upload-pages-artifact-2 GH Actions: Bump actions/upload-pages-artifact from 1 to 2
No need to check on a daily basis. ("daily" was only really used to be able to test the setup)
Follow up on 298 in which I explicitly stated:
> Once the configuration has been "finalized" (I use that term loosely), this should be changed to run the Dependabot check only once a week.
…frequency Dependabot: switch to weekly
PHP-Coveralls 2.6.0 has just been released and includes a fix for the last known PHP 8.x issue. This means that it should now be safe to install php-coveralls on PHP 8.x and upload from there, which means we now only need the work-around for the PHP version when on PHP < 5.5 (as Coveralls v1 does not work with GH Actions). Ref: * https://github.com/php-coveralls/php-coveralls/releases/tag/v2.6.0
…-php-coveralls-2.6.0 GH Actions: update for php-coveralls 2.6.0
... when the second pointer passed is a comment token and the comment is the last content of the current file. Includes tests.
…-defensive-coding SpacesFixer: prevent an unwarranted exception
Follow up on 451 Upstream PR squizlabs/PHP_CodeSniffer 3797, which will be included in PHPCS 3.8.0, fixes a tokenizer issue which affected the `File::getDeclarationName()` and, by extension, the `BackCompat::getDeclarationName()` method. The function name for functions named `self`, `parent` or `static` and declared to return by reference, could previously not be retrieved. The PHPCSUtils native version of the method `ObjectDeclarations::getName()` already handled things correctly. This commit adds back the BC-layer for the `getDeclarationName()` method and polyfills the fix from PHPCS 3.8.0 to backport it for PHPCS < 3.8.0. As the methods will now handle these functions in the same way, this commit also moves the related tests from the `GetNameDiffTest` to the `GetDeclarationNameTest`.
…arationname-sync-with-upstream BCFile::getDeclarationName(): sync with upstream
Changelog for PHPCSUtils 1.0.8
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release checklist
General
composer.json- N/A✏️ Remember to add a release link at the bottom!
Release
develop!) & copy & paste the changelog to it.✏️ Don't forget to copy the link collection from the bottom of the changelog!
developto be equal tostablePublicize