Switch to PHPCSStandards/PHP_CodeSniffer & raise minimum supported version #523
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrfnl
force-pushed
the
feature/switch-to-fork-of-phpcs
branch
3 times, most recently
from
dba98a4
to
a35a07e
Compare
The Squizlabs repo has been abandoned. The project continues in a fork in the PHPCSStandards organisation. Ref: * squizlabs/PHP_CodeSniffer 3932
... to prevent end-users from running into trouble with the name change. The files in the Composer `vendor/bin` will only be replaced when the `replace...` directive is found and that is only available in the 3.8.0 tag. When the files in the Composer `vendor/bin` are not replaced, they will continue to point to the `vendor/squizlabs/php_codesniffer` directory which will no longer exist, leading to fatal "File not found" errors for end-users trying to run PHPCS/PHPCBF. Includes updating references to the PHPCS version whenever relevant throughout the codebase.
jrfnl
force-pushed
the
feature/switch-to-fork-of-phpcs
branch
from
a35a07e
to
2f73b96
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(which contains the Composer, this can/should be mergedreplacedirective)and released ASAP.Switch to PHPCSStandards/PHP_CodeSniffer
The Squizlabs repo has been abandoned. The project continues in a fork in the PHPCSStandards organisation.
Ref:
Composer: raise the minimum supported PHPCS version to 3.8.0
... to prevent end-users from running into trouble with the name change.
The files in the Composervendor/binwill only be replaced when thereplace...directive is found and that is only available in the 3.8.0 tag.When the files in the Composervendor/binare not replaced, they will continue to point to thevendor/squizlabs/php_codesnifferdirectory which will no longer exist, leading to fatal "File not found" errors for end-users trying to run PHPCS/PHPCBF.Includes updating references to the PHPCS version whenever relevant throughout the codebase.
Update: The Composer package name will not change, so while this PR should still be merged at our convenience (after the 3.8.0 release, expected this Friday), we will not need to do a release to unblock end-users, only because we actually have changes which are useful for end-users.
Remove work-arounds which were in place for PHPCS < 3.8.0